feat: extract text from PreviewFormBanner and mutation files into sep…#9266
Open
brendancjz wants to merge 3 commits intoopengovsg:developfrom
Open
feat: extract text from PreviewFormBanner and mutation files into sep…#9266brendancjz wants to merge 3 commits intoopengovsg:developfrom
brendancjz wants to merge 3 commits intoopengovsg:developfrom
Conversation
Contributor
Author
|
Hey @LoneRifle for your review. Tried running Running |
LoneRifle
requested changes
Apr 1, 2026
Contributor
LoneRifle
left a comment
LoneRifle
left a comment
There was a problem hiding this comment.
correct these first - i'll look into the PR again once done
Contributor
Author
Hey @LoneRifle, made the changes. Let me know if you have further comments thanks! |
Contributor
|
The Forms team is backed up and they haven't gotten round to merging your other PRs to mainline. Deliberately introducing some backpressure here so that they don't get overwhelmed. Hang tight for now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #8454
Solution
Breaking Changes
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER:
Tests
Deploy Notes
New environment variables:
env var: env var detailsNew scripts:
script: script detailsNew dependencies:
dependency: dependency detailsNew dev dependencies:
dependency: dependency details